HWBOT
  1. HWBOT
  2. HWBOT-981

Possible to edit score of a submission

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: hwbot v5.5.0
    • Labels:
      None

      Description

      Reported by XTU but apparently this was the case for all benchmarks.
      When a user editted his own submission, he was able to edit the score field. Only admins and super moderators should be able to edit the score field.

        Activity

        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2757 (See [http://dev.hwbot.org/job/HWBOT%20v4/2757/])
            HWBOT-981

        Users should not be able to edit their own scores when editting a submission

        dennis :
        Files :
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/includes/submit.score.jsp
        * /hwbot/trunk/src/main/resources/i18n/translations.properties
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/includes/submit.score.time.jsp
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/submit.form.jsp
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2757 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2757/ ])      HWBOT-981 Users should not be able to edit their own scores when editting a submission dennis : Files : * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/includes/submit.score.jsp * /hwbot/trunk/src/main/resources/i18n/translations.properties * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/includes/submit.score.time.jsp * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/submit.form.jsp
        Hide
        Dennis Devriendt added a comment -
        Reverted the change: when editting a result, submission owners ARE allowed to edit the score.
        Show
        Dennis Devriendt added a comment - Reverted the change: when editting a result, submission owners ARE allowed to edit the score.
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2760 (See [http://dev.hwbot.org/job/HWBOT%20v4/2760/])
            HWBOT-981

        Users should not be able to edit their own scores when editting a submission

        dennis :
        Files :
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/includes/submit.score.jsp
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2760 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2760/ ])      HWBOT-981 Users should not be able to edit their own scores when editting a submission dennis : Files : * /hwbot/trunk/src/main/webapp/WEB-INF/views/submit/includes/submit.score.jsp
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2762 (See [http://dev.hwbot.org/job/HWBOT%20v4/2762/])
            HWBOT-981 Possible to edit score of a submission

        dennis :
        Files :
        * /hwbot/trunk/src/test/java/org/hwbot/integration/XtuSeleniumTest.java
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2762 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2762/ ])      HWBOT-981 Possible to edit score of a submission dennis : Files : * /hwbot/trunk/src/test/java/org/hwbot/integration/XtuSeleniumTest.java
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2766 (See [http://dev.hwbot.org/job/HWBOT%20v4/2766/])
            HWBOT-981 Possible to edit score of a submission
        HWBOT-981 Possible to edit score of a submission

        dennis :
        Files :
        * /hwbot/trunk/src/test/java/org/hwbot/integration/XtuSeleniumTest.java

        dennis :
        Files :
        * /hwbot/trunk/src/test/java/org/hwbot/integration/XtuSeleniumTest.java
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2766 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2766/ ])      HWBOT-981 Possible to edit score of a submission HWBOT-981 Possible to edit score of a submission dennis : Files : * /hwbot/trunk/src/test/java/org/hwbot/integration/XtuSeleniumTest.java dennis : Files : * /hwbot/trunk/src/test/java/org/hwbot/integration/XtuSeleniumTest.java

          People

          • Assignee:
            Dennis Devriendt
            Reporter:
            Dennis Devriendt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: