HWBOT
  1. HWBOT
  2. HWBOT-963

Contribute points to your team achievement still bugged

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: hwbot v5.7.0
    • Labels:
      None

      Description

      Reported by GENiBEN

        Activity

        Hide
        Pieter-Jan Plaisier added a comment -
        Attached the 10k pts screenshot to this issue. User has ~ 3900 points, but the 10k achievement says 1.7k
        Show
        Pieter-Jan Plaisier added a comment - Attached the 10k pts screenshot to this issue. User has ~ 3900 points, but the 10k achievement says 1.7k
        Hide
        Dennis Devriendt added a comment -
        I think the achievement calculations are correct but the ones that were broken in the past are still broken because they aren't considered for recalculation. Maybe it's possible to fix it by throwing away the progress for each achievement but recalculating would take a very very long time then. Not sure if there's a more clever way to fix them, I'd have to know more about the code :).
        Show
        Dennis Devriendt added a comment - I think the achievement calculations are correct but the ones that were broken in the past are still broken because they aren't considered for recalculation. Maybe it's possible to fix it by throwing away the progress for each achievement but recalculating would take a very very long time then. Not sure if there's a more clever way to fix them, I'd have to know more about the code :).
        Hide
        Dennis Devriendt added a comment -
        different queries were used to check the achievement. It now uses: SELECT SUM(re.points) FROM rank_entry re join result r using (result_id) join custom_rank cr on (cr.rank_id = re.rank_id) WHERE (r.status_id<10 and r.user_id=:userId) and (cr.type = 'team_hardware' or cr.type = 'team_global');

        Unfortunately the 1/10 UP aren't added to this but that would add a lot of complexity to these achievements.
        Show
        Dennis Devriendt added a comment - different queries were used to check the achievement. It now uses: SELECT SUM(re.points) FROM rank_entry re join result r using (result_id) join custom_rank cr on (cr.rank_id = re.rank_id) WHERE (r.status_id<10 and r.user_id=:userId) and (cr.type = 'team_hardware' or cr.type = 'team_global'); Unfortunately the 1/10 UP aren't added to this but that would add a lot of complexity to these achievements.

          People

          • Assignee:
            Dennis Devriendt
            Reporter:
            Pieter-Jan Plaisier
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: