Details

    • Type: Sub Task Sub Task
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: hwbot v5, hwbot v5.4.0
    • Labels:
      None

      Description

      Who joined or left the team. Visual timeline would be nice.

        Activity

        Hide
        Dennis Devriendt added a comment -
        Technical stuff is almost done. There are some issues:
        - won't work in tab: ReferenceError: google is not defined
        - possible to test if you edit the views.xml so that /tab/timeline extends the 1column layout
        - lots of css improvements needed
        - add more notifications for competition: not only winners should get notification, all participants should get one
        - extra feature: users should be able to filter notifications
        Show
        Dennis Devriendt added a comment - Technical stuff is almost done. There are some issues: - won't work in tab: ReferenceError: google is not defined - possible to test if you edit the views.xml so that /tab/timeline extends the 1column layout - lots of css improvements needed - add more notifications for competition: not only winners should get notification, all participants should get one - extra feature: users should be able to filter notifications
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2638 (See [http://dev.hwbot.org/job/HWBOT%20v4/2638/])
            HWBOT-820

        Track history of (competition) teams

        - won't work in tab: ReferenceError: google is not defined
        - possible to test if you edit the views.xml so that /tab/timeline extends the 1column layout

        dennis :
        Files :
        * /hwbot/trunk/src/main/resources/i18n/translations.properties
        * /hwbot/trunk/src/main/webapp/css/style.css
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/TeamController.java
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/views.xml
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/notification/notificationList.jsp
        * /hwbot/trunk/src/main/java/org/hwbot/facade/CompetitionFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacade.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/persistence/Notification.java
        * /hwbot/trunk/src/main/resources/i18n/translations-dynamic.properties
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfileTimelineTab.jsp
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfile.jsp
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/NotificationController.java
        * /hwbot/trunk/src/main/java/org/hwbot/util/DateUtil.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/UserFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/ProfileController.java
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2638 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2638/ ])      HWBOT-820 Track history of (competition) teams - won't work in tab: ReferenceError: google is not defined - possible to test if you edit the views.xml so that /tab/timeline extends the 1column layout dennis : Files : * /hwbot/trunk/src/main/resources/i18n/translations.properties * /hwbot/trunk/src/main/webapp/css/style.css * /hwbot/trunk/src/main/java/org/hwbot/web/actions/TeamController.java * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/views.xml * /hwbot/trunk/src/main/webapp/WEB-INF/views/notification/notificationList.jsp * /hwbot/trunk/src/main/java/org/hwbot/facade/CompetitionFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacade.java * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/persistence/Notification.java * /hwbot/trunk/src/main/resources/i18n/translations-dynamic.properties * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfileTimelineTab.jsp * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfile.jsp * /hwbot/trunk/src/main/java/org/hwbot/web/actions/NotificationController.java * /hwbot/trunk/src/main/java/org/hwbot/util/DateUtil.java * /hwbot/trunk/src/main/java/org/hwbot/facade/UserFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/web/actions/ProfileController.java
        Hide
        Dennis Devriendt added a comment -
        As discussed, following changes should be implemented:
        - move the graph to the teamprofile page
        - more notifications for competitions (every participant should get a notification with their position)
        - make links next to POINTS, RANKING, MEMBERS (to be added), ACHIEVEMENTS, which will update the graph (also appropriate notifications, for example join/leave with members)
        Show
        Dennis Devriendt added a comment - As discussed, following changes should be implemented: - move the graph to the teamprofile page - more notifications for competitions (every participant should get a notification with their position) - make links next to POINTS, RANKING, MEMBERS (to be added), ACHIEVEMENTS, which will update the graph (also appropriate notifications, for example join/leave with members)
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2645 (See [http://dev.hwbot.org/job/HWBOT%20v4/2645/])
            HWBOT-820

        Track history of (competition) teams

        dennis :
        Files :
        * /hwbot/trunk/src/main/webapp/css/style.css
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/TeamController.java
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/views.xml
        * /hwbot/trunk/src/main/java/org/hwbot/facade/CompetitionFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/ChartController.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacade.java
        * /hwbot/trunk/src/main/torque/scripts/update.sql
        * /hwbot/trunk/src/main/java/org/hwbot/persistence/Notification.java
        * /hwbot/trunk/src/main/resources/i18n/translations-dynamic.properties
        * /hwbot/trunk/src/main/torque/schema/hwbot-schema.xml
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfile.jsp
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfileTimelineTab.jsp
        * /hwbot/trunk/src/main/resources/META-INF/ranking-queries.xml
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/NotificationController.java
        * /hwbot/trunk/src/main/java/org/hwbot/jpa/TeamPoints.java
        * /hwbot/trunk/src/main/java/org/hwbot/util/DateUtil.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/UserFacadeImpl.java
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2645 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2645/ ])      HWBOT-820 Track history of (competition) teams dennis : Files : * /hwbot/trunk/src/main/webapp/css/style.css * /hwbot/trunk/src/main/java/org/hwbot/web/actions/TeamController.java * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/views.xml * /hwbot/trunk/src/main/java/org/hwbot/facade/CompetitionFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/web/actions/ChartController.java * /hwbot/trunk/src/main/java/org/hwbot/facade/ChartFacade.java * /hwbot/trunk/src/main/torque/scripts/update.sql * /hwbot/trunk/src/main/java/org/hwbot/persistence/Notification.java * /hwbot/trunk/src/main/resources/i18n/translations-dynamic.properties * /hwbot/trunk/src/main/torque/schema/hwbot-schema.xml * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfile.jsp * /hwbot/trunk/src/main/webapp/WEB-INF/views/team/teamProfileTimelineTab.jsp * /hwbot/trunk/src/main/resources/META-INF/ranking-queries.xml * /hwbot/trunk/src/main/java/org/hwbot/web/actions/NotificationController.java * /hwbot/trunk/src/main/java/org/hwbot/jpa/TeamPoints.java * /hwbot/trunk/src/main/java/org/hwbot/util/DateUtil.java * /hwbot/trunk/src/main/java/org/hwbot/facade/UserFacadeImpl.java
        Hide
        Dennis Devriendt added a comment -
        Updated, remarks:

        - CSS still needs to be fixed (correct width, padding, annotations on the right side going out of bounds, when the graph is loading, the div is not in the correct place)

        - there are icons next to ranking, points, members and achievements for the different graphs but they should be clearer somehow, not sure how to do it in a clean way

        - currently associated annotations, also not sure how to improve:
        points: members joined/left, team position after a competition
        rank: members joined/left, team position after a competition
        members: members joined/left
        achievements: names of achievements the team received
        I don't think adding the "user has submitted x" notifications as annotations is a good idea, there would just be too many.
        Show
        Dennis Devriendt added a comment - Updated, remarks: - CSS still needs to be fixed (correct width, padding, annotations on the right side going out of bounds, when the graph is loading, the div is not in the correct place) - there are icons next to ranking, points, members and achievements for the different graphs but they should be clearer somehow, not sure how to do it in a clean way - currently associated annotations, also not sure how to improve: points: members joined/left, team position after a competition rank: members joined/left, team position after a competition members: members joined/left achievements: names of achievements the team received I don't think adding the "user has submitted x" notifications as annotations is a good idea, there would just be too many.
        Hide
        Dennis Devriendt added a comment -
        - graph shouldn't grab focus, it prevents scrolling down on the site
        - the graph is zoomed all the way out. I think it would be more relevant to set the default zoom to the last year or so, the problem with that is that if the first datapoint starts today, the graph will still show an "empty year".
        Show
        Dennis Devriendt added a comment - - graph shouldn't grab focus, it prevents scrolling down on the site - the graph is zoomed all the way out. I think it would be more relevant to set the default zoom to the last year or so, the problem with that is that if the first datapoint starts today, the graph will still show an "empty year".

          People

          • Assignee:
            Dennis Devriendt
            Reporter:
            Frederik Colardyn
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: