HWBOT
  1. HWBOT
  2. HWBOT-798

Non-partner names should be hidden in the WR table

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: hwbot v4.6.12
    • Labels:
      None

      Description

      http://hwbot.org/benchmark/superpi_32m/halloffame

      "Asus", for example, should not be visible. Imho ... we also shouldn't show their product names in this table (which is going to be used for marketing purposes a lot).

        Activity

        Hide
        Pieter-Jan Plaisier added a comment -
        http://hwbot.org/benchmark/3dmark_vantage_-_performance/halloffame

        Processor should be "videocard" + vendor and series should be mentioned (now only product name, I think)
        Show
        Pieter-Jan Plaisier added a comment - http://hwbot.org/benchmark/3dmark_vantage_-_performance/halloffame Processor should be "videocard" + vendor and series should be mentioned (now only product name, I think)
        Hide
        Dennis Devriendt added a comment -
        - new method in Manufacturer class: isShowWrProductName (partner level >= 1)
        - motherboard field is completely empty if manufacturer is no partner
        - the specific hardware field (videocard for example for 3Dmark) shows vendor and gpu model. If vendor is no partner, only gpu model is shown
        - improved various things with the world record pages
        Show
        Dennis Devriendt added a comment - - new method in Manufacturer class: isShowWrProductName (partner level >= 1) - motherboard field is completely empty if manufacturer is no partner - the specific hardware field (videocard for example for 3Dmark) shows vendor and gpu model. If vendor is no partner, only gpu model is shown - improved various things with the world record pages
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2573 (See [http://dev.hwbot.org/job/HWBOT%20v4/2573/])
            HWBOT-798

        Non-partner names should be hidden in the WR table

        dennis :
        Files :
        * /hwbot/trunk/src/main/resources/i18n/translations.properties
        * /hwbot/trunk/src/main/java/org/hwbot/persistence/Hardware.java
        * /hwbot/trunk/src/main/java/org/hwbot/persistence/Manufacturer.java
        * /hwbot/trunk/src/main/webapp/includes/ranking/ranking.app.jsp
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/benchmark/hallOfFame.jsp
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2573 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2573/ ])      HWBOT-798 Non-partner names should be hidden in the WR table dennis : Files : * /hwbot/trunk/src/main/resources/i18n/translations.properties * /hwbot/trunk/src/main/java/org/hwbot/persistence/Hardware.java * /hwbot/trunk/src/main/java/org/hwbot/persistence/Manufacturer.java * /hwbot/trunk/src/main/webapp/includes/ranking/ranking.app.jsp * /hwbot/trunk/src/main/webapp/WEB-INF/views/benchmark/hallOfFame.jsp

          People

          • Assignee:
            Frederik Colardyn
            Reporter:
            Pieter-Jan Plaisier
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: