HWBOT
  1. HWBOT
  2. HWBOT-1064

When a submission changes hw ranking, old ranking is not recalculated

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: hwbot v5.9.0
    • Labels:
      None

      Description

      For example a CPU benchmark submission has the wrong CPU model. A moderator changes the CPU which changes the hardware ranking it will participate in.
      The new hardware ranking is recalculated but the old ranking isn't, which causes other results in the old ranking to have a lower score than they should.

        Activity

        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2911 (See [http://dev.hwbot.org/job/HWBOT%20v4/2911/])
            HWBOT-1064

        When a submission changes hw ranking, old ranking is not recalculated

        dennis :
        Files :
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/ResultRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamRankingUpdater.java
        * /hwbot/trunk/src/test/resources/dbunit/hwbot-primer.xml
        * /hwbot/trunk/src/main/webapp/WEB-INF/views/competition/sidebar.jsp
        * /hwbot/trunk/src/main/java/org/hwbot/facade/CompetitionFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserCompetitionRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/ResultFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/ResultFacade.java
        * /hwbot/trunk/src/main/java/org/hwbot/web/actions/SubmitController.java
        * /hwbot/trunk/src/main/webapp/css/style-asrock.css
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserAchievementUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingFacadeImpl.java
        * /hwbot/trunk/src/test/java/org/hwbot/facade/ResultFacadeImplTest.java
        * /hwbot/trunk/src/main/java/org/hwbot/web/servlet/RecalculateServlet.java
        * /hwbot/trunk/src/test/java/org/hwbot/ranking/RankingUpdaterTest.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserCompetitionStageRankingUpdater.java
        * /hwbot/trunk/src/main/webapp/css/style-aooc.css
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/HardwareRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/WorldRecordRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingJob.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamHardwareRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/DefaultRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingProcessorThread.java
        * /hwbot/trunk/src/main/java/org/hwbot/facade/UserFacadeImpl.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/GlobalRankingUpdater.java
        * /hwbot/trunk/src/torque/report.hwbot.om.base.generation
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/CompetitionParticipationRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/UpdateEvent.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamGlobalRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/RankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserLeagueUpdater.java
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2911 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2911/ ])      HWBOT-1064 When a submission changes hw ranking, old ranking is not recalculated dennis : Files : * /hwbot/trunk/src/main/java/org/hwbot/ranking/ResultRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamRankingUpdater.java * /hwbot/trunk/src/test/resources/dbunit/hwbot-primer.xml * /hwbot/trunk/src/main/webapp/WEB-INF/views/competition/sidebar.jsp * /hwbot/trunk/src/main/java/org/hwbot/facade/CompetitionFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserCompetitionRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/facade/ResultFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/facade/ResultFacade.java * /hwbot/trunk/src/main/java/org/hwbot/web/actions/SubmitController.java * /hwbot/trunk/src/main/webapp/css/style-asrock.css * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserAchievementUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingFacadeImpl.java * /hwbot/trunk/src/test/java/org/hwbot/facade/ResultFacadeImplTest.java * /hwbot/trunk/src/main/java/org/hwbot/web/servlet/RecalculateServlet.java * /hwbot/trunk/src/test/java/org/hwbot/ranking/RankingUpdaterTest.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserCompetitionStageRankingUpdater.java * /hwbot/trunk/src/main/webapp/css/style-aooc.css * /hwbot/trunk/src/main/java/org/hwbot/ranking/HardwareRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/WorldRecordRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingJob.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamHardwareRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/DefaultRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingProcessorThread.java * /hwbot/trunk/src/main/java/org/hwbot/facade/UserFacadeImpl.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/GlobalRankingUpdater.java * /hwbot/trunk/src/torque/report.hwbot.om.base.generation * /hwbot/trunk/src/main/java/org/hwbot/ranking/CompetitionParticipationRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/UpdateEvent.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamGlobalRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/RankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/UserLeagueUpdater.java
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2915 (See [http://dev.hwbot.org/job/HWBOT%20v4/2915/])
            HWBOT-1064

        When a submission changes hw ranking, old ranking is not recalculated

        dennis :
        Files :
        * /hwbot/trunk/src/test/java/org/hwbot/facade/ResultFacadeImplTest.java
        * /hwbot/trunk/src/test/java/org/hwbot/facade/RankingFacadeImplTest.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/HardwareRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamHardwareRankingUpdater.java
        * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamGlobalRankingUpdater.java
        * /hwbot/trunk/src/torque/report.hwbot.sql.generation
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2915 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2915/ ])      HWBOT-1064 When a submission changes hw ranking, old ranking is not recalculated dennis : Files : * /hwbot/trunk/src/test/java/org/hwbot/facade/ResultFacadeImplTest.java * /hwbot/trunk/src/test/java/org/hwbot/facade/RankingFacadeImplTest.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/HardwareRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamHardwareRankingUpdater.java * /hwbot/trunk/src/main/java/org/hwbot/ranking/TeamGlobalRankingUpdater.java * /hwbot/trunk/src/torque/report.hwbot.sql.generation
        Hide
        Build Server added a comment -
        Integrated in HWBOT v4 #2916 (See [http://dev.hwbot.org/job/HWBOT%20v4/2916/])
            HWBOT-1064

        When a submission changes hw ranking, old ranking is not recalculated

        dennis :
        Files :
        * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingFacadeImpl.java
        * /hwbot/trunk/src/main/resources/META-INF/ranking-queries.xml
        Show
        Build Server added a comment - Integrated in HWBOT v4 #2916 (See [ http://dev.hwbot.org/job/HWBOT%20v4/2916/ ])      HWBOT-1064 When a submission changes hw ranking, old ranking is not recalculated dennis : Files : * /hwbot/trunk/src/main/java/org/hwbot/facade/RankingFacadeImpl.java * /hwbot/trunk/src/main/resources/META-INF/ranking-queries.xml

          People

          • Assignee:
            Dennis Devriendt
            Reporter:
            Dennis Devriendt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: